Add Anisotropic Sampling option to ZZZ GSP #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AKA Anisotropic Filtering, but kept the in-game name for clarity. All presets seem to not change the value, keeping it at x8.
|
bagusnl
approved these changes
Mar 17, 2025
| /// Sets the in-game quality settings for Anisotropic Sampling | ||
| /// </summary> | ||
| /// <see cref="AnisotropicSamplingOption"/> | ||
|
|
| @@ -1574,6 +1574,7 @@ | |||
| "Graphics_EffectsQ": "Effects Quality", | |||
| "Graphics_ShadingQ": "Shading Quality", | |||
| "Graphics_Distortion": "Distortion", | |||
| "Graphics_AnisotropicSampling": "Anisotropic Sampling", | |||
There was a problem hiding this comment.
Technically this is already available under _GenshinGameSettingsPage, I think we can reuse it instead of telling localizer to resubmit exactly the same thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AKA Anisotropic Filtering, but kept the in-game name for clarity. All presets seem to not change the value, keeping it at x8.
Main Goal
Update ZZZ GSP so that it is in parity with the in-game options.
PR Status :
Changes: